fix pod for add_order_by args to be hash instead of hashref by hogashi · Pull Request #53 · tokuhirom/SQL-Maker

hogashi · 2025-08-01T06:15:23Z

got

Pod says that add_order_by takes string or hashref as arguments.

$stmt->add_order_by('foo');
$stmt->add_order_by({'foo' => 'DESC'});

expected

add_order_by takes string or hash (or scalar ref). ref:

SQL-Maker/t/select/01_statement.t

Lines 370 to 418 in 0a5b718

    
           subtest 'ORDER BY' => sub { 
        
               subtest 'quote_char: "`", name_sep: "."' => sub { 
        
                   do { 
        
                       my $stmt = ns( quote_char => q{`}, name_sep => q{.}, ); 
        
                       $stmt->add_from( 'foo' ); 
        
                       $stmt->add_order_by('baz' => 'DESC'); 
        
                       is($stmt->as_sql, "FROM `foo`\nORDER BY `baz` DESC", 'single order by'); 
        
                   }; 
        
                   do { 
        
                       my $stmt = ns( quote_char => q{`}, name_sep => q{.}, ); 
        
                       $stmt->add_from( 'foo' ); 
        
                       $stmt->add_order_by( 'baz' => 'DESC' ); 
        
                       $stmt->add_order_by( 'quux' => 'ASC' ); 
        
                       is($stmt->as_sql, "FROM `foo`\nORDER BY `baz` DESC, `quux` ASC", 'multiple order by'); 
        
                   }; 
        
                   do { 
        
                       my $stmt = ns( quote_char => q{`}, name_sep => q{.}, ); 
        
                       $stmt->add_from( 'foo' ); 
        
                       $stmt->add_order_by( \'baz DESC' ); 
        
                       is($stmt->as_sql, "FROM `foo`\nORDER BY baz DESC", 'scalar ref'); # should not quote 
        
                   }; 
        
               }; 
        
               subtest 'quote_char: "", name_sep: ".", new_line: " "' => sub { 
        
                   do { 
        
                       my $stmt = ns( quote_char => q{}, name_sep => q{.}, new_line => q{ } ); 
        
                       $stmt->add_from( 'foo' ); 
        
                       $stmt->add_order_by('baz' => 'DESC'); 
        
                       is($stmt->as_sql, "FROM foo ORDER BY baz DESC", 'single order by'); 
        
                   }; 
        
                   do { 
        
                       my $stmt = ns( quote_char => q{}, name_sep => q{.}, new_line => q{ }); 
        
                       $stmt->add_from( 'foo' ); 
        
                       $stmt->add_order_by( 'baz' => 'DESC' ); 
        
                       $stmt->add_order_by( 'quux' => 'ASC' ); 
        
                       is($stmt->as_sql, "FROM foo ORDER BY baz DESC, quux ASC", 'multiple order by'); 
        
                   }; 
        
                   subtest 'scalarref' => sub { 
        
                       my $stmt = ns( quote_char => q{}, name_sep => q{.}, new_line => q{ }); 
        
                       $stmt->add_from( 'foo' ); 
        
                       $stmt->add_order_by( \'baz DESC' ); 
        
                       is($stmt->as_sql, "FROM foo ORDER BY baz DESC"); # should not quote 
        
                   }; 
        
               }; 
        
           };

what I did

I fixed pod for add_order_by arguments to be hash instead of hashref.

fix pod for add_order_by args to be hash instead of hashref

e1a0915

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix pod for add_order_by args to be hash instead of hashref#53

fix pod for add_order_by args to be hash instead of hashref#53
hogashi wants to merge 1 commit intotokuhirom:masterfrom
hogashi:patch-1

hogashi commented Aug 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	subtest 'ORDER BY' => sub {
	subtest 'quote_char: "`", name_sep: "."' => sub {
	do {
	my $stmt = ns( quote_char => q{`}, name_sep => q{.}, );
	$stmt->add_from( 'foo' );
	$stmt->add_order_by('baz' => 'DESC');
	is($stmt->as_sql, "FROM `foo`\nORDER BY `baz` DESC", 'single order by');
	};

	do {
	my $stmt = ns( quote_char => q{`}, name_sep => q{.}, );
	$stmt->add_from( 'foo' );
	$stmt->add_order_by( 'baz' => 'DESC' );
	$stmt->add_order_by( 'quux' => 'ASC' );
	is($stmt->as_sql, "FROM `foo`\nORDER BY `baz` DESC, `quux` ASC", 'multiple order by');
	};

	do {
	my $stmt = ns( quote_char => q{`}, name_sep => q{.}, );
	$stmt->add_from( 'foo' );
	$stmt->add_order_by( \'baz DESC' );
	is($stmt->as_sql, "FROM `foo`\nORDER BY baz DESC", 'scalar ref'); # should not quote
	};
	};

	subtest 'quote_char: "", name_sep: ".", new_line: " "' => sub {
	do {
	my $stmt = ns( quote_char => q{}, name_sep => q{.}, new_line => q{ } );
	$stmt->add_from( 'foo' );
	$stmt->add_order_by('baz' => 'DESC');
	is($stmt->as_sql, "FROM foo ORDER BY baz DESC", 'single order by');
	};

	do {
	my $stmt = ns( quote_char => q{}, name_sep => q{.}, new_line => q{ });
	$stmt->add_from( 'foo' );
	$stmt->add_order_by( 'baz' => 'DESC' );
	$stmt->add_order_by( 'quux' => 'ASC' );
	is($stmt->as_sql, "FROM foo ORDER BY baz DESC, quux ASC", 'multiple order by');
	};

	subtest 'scalarref' => sub {
	my $stmt = ns( quote_char => q{}, name_sep => q{.}, new_line => q{ });
	$stmt->add_from( 'foo' );
	$stmt->add_order_by( \'baz DESC' );
	is($stmt->as_sql, "FROM foo ORDER BY baz DESC"); # should not quote
	};
	};
	};

Conversation

hogashi commented Aug 1, 2025

got

expected

what I did

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant